[Poppler-bugs] [Bug 89097] [patch] inline some frequently called stream functions

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 12 11:24:01 PST 2015


https://bugs.freedesktop.org/show_bug.cgi?id=89097

--- Comment #1 from Albert Astals Cid <aacid at kde.org> ---
This doesn't really make much sense, makes the code somewhat harder to read and
makes future patching from xpdf harder for no win since those calls can't be
inlined, see http://www.parashift.com/c++-faq-lite/inline-virtuals.html

So i'd prefer not accepting this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150212/b879a7d8/attachment-0001.html>


More information about the Poppler-bugs mailing list