[Poppler-bugs] [Bug 89097] [patch] inline some frequently called stream functions

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89097

--- Comment #2 from William Bader <williambader at hotmail.com> ---
OK.
It didn't seem to make much of a performance difference since the getChar()
functions are virtual and can't be inlined.
I think that a better solution is making the low-level Stream interface based
on filling buffers rather than passing characters one at a time.
The profile above has 111M calls to one of the getChar() functions.
Would it be possible to have only one non-virtual getChar() in Stream that
calls a virtual function to fill a buffer as needed?
At worst the buffer fill function could just load the one character that
getChar() would have returned, so it would not require a redesign of streams
that can provide only one character at a time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150212/7c7c842c/attachment.html>