[Poppler-bugs] [Bug 91384] New: [patch] shlobj.h is missing #defines without including windows.h first

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Jul 18 07:52:26 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=91384

            Bug ID: 91384
           Summary: [patch] shlobj.h is missing #defines without including
                    windows.h first
           Product: poppler
           Version: unspecified
          Hardware: Other
                OS: Windows (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: drawoc at darkrefraction.com

Created attachment 117232
  --> https://bugs.freedesktop.org/attachment.cgi?id=117232&action=edit
Patch to fix including shlobj.h

When cross-compiling poppler for windows using mingw, I get the following
error:

In file included from GlobalParams.cc:59:0:
/usr/i686-w64-mingw32/include/shlobj.h:37:3: error: 'EXTERN_C' does not name a
type
   SHFOLDERAPI SHGetFolderPathW (HWND hwnd, int csidl, HANDLE hToken, DWORD
dwFlags, LPWSTR pszPath);
   ^

It seems that simply including windows.h before shlobj.h pulls in the necessary
definitions for shlobj.h and fixes this issue. See attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150718/f24b4d18/attachment.html>


More information about the Poppler-bugs mailing list