[Poppler-bugs] [Bug 90066] pdfunite: embedded files discarded during merge

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90066

--- Comment #13 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
(In reply to Albert Astals Cid from comment #11)
> Thomas, don't
>  GooString *newKey = new GooString("Names");
> and
>  GooString *newKey = new GooString(key);
> 
> leak too?

Sorry for the delay. I just looked into it again, and yes, in case of keys in a
Dict the choice of "new GooString" is definitely wrong, it could not cause only
a memory leak, in case of the static version of GooString it could also cause
memory corruption. I have to use copyString in this cases. I wonder a little
bit why valgrind didn't show me that problem.

I will upload a new patch in a few minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150720/9c19ff25/attachment.html>