[Poppler-bugs] [Bug 93229] remove or deprecate PopplerOrientation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93229

Christophe Fergeau <teuf at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
                 CC|                            |teuf at gnome.org

--- Comment #4 from Christophe Fergeau <teuf at gnome.org> ---
This unfortunately breaks both ABI and API for pypoppler. PopplerOrientation
was defined in poppler.h, which is passed to glib-mkenums in order to generate
the public header poppler-enums.h, and the diff for this header before/after
this commit is:

--- poppler-enums.h     2016-04-28 10:46:57.709931818 +0200
+++ glib/poppler-enums.h        2016-04-28 10:46:58.790928198 +0200
@@ -92,6 +92,8 @@
 /* enumerations from "poppler.h" */
 GType poppler_error_get_type (void) G_GNUC_CONST;
 #define POPPLER_TYPE_ERROR (poppler_error_get_type ())
+GType poppler_orientation_get_type (void) G_GNUC_CONST;
+#define POPPLER_TYPE_ORIENTATION (poppler_orientation_get_type ())
 GType poppler_page_transition_type_get_type (void) G_GNUC_CONST;
 #define POPPLER_TYPE_PAGE_TRANSITION_TYPE
(poppler_page_transition_type_get_type ())
 GType poppler_page_transition_alignment_get_type (void) G_GNUC_CONST;


ABI break is https://bugzilla.redhat.com/show_bug.cgi?id=1323497
$pdfshuffler 

Error: Could not import pdfshuffler
Cause: /usr/lib64/python2.7/site-packages/poppler.so: undefined symbol:
poppler_orientation_get_type



API break is https://bugzilla.redhat.com/show_bug.cgi?id=1307888

poppler.c: In function 'py_poppler_add_constants':
poppler.c:4628:53: error: 'POPPLER_TYPE_ORIENTATION' undeclared (first use in
this function)
   pyg_enum_add(module, "Orientation", strip_prefix, POPPLER_TYPE_ORIENTATION);
poppler.c:4628:53: note: each undeclared identifier is reported only once for
each function it appears in
Makefile:430: recipe for target 'poppler_la-poppler.lo' failed


I'll look at patching pypoppler, but these changes on poppler-glib side were
unexpected ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160428/b3018898/attachment.html>