[Poppler-bugs] [Bug 94201] New: refactor GooString

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94201

            Bug ID: 94201
           Summary: refactor GooString
           Product: poppler
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: jakubkucharski97 at gmail.com

Created attachment 121823
  --> https://bugs.freedesktop.org/attachment.cgi?id=121823&action=edit
patch

I've run The Clang Static Analyzer on poppler and among others there were some
issues with GooString. And so I discovered that GooString::Set() is used only
once to concatenate strings and it is in a GooString constructor used
specifically for that, so I think concatenation should take place in the
constructor and GooString::Set should do exactly what it says which is setting
the string.

In GooString::resize() there was a bug that under some circumstances would
effect in one of the arguments passed to memcpy being NULL. Another problem is
the use of memcpy. Given the possible prior use of realloc we can't be sure
that s doesn't point to an area somewhere in [s1, newLength), so it's
reasonable to call memmove instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160218/0724807e/attachment-0001.html>