[Poppler-bugs] [Bug 94201] refactor GooString

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94201

--- Comment #6 from Jakub Kucharski <jakubkucharski97 at gmail.com> ---
(In reply to Albert Astals Cid from comment #5)
> Can you explain why we need the 
> 
> "(s &&" part?
> 
> I don't see why it would be needed.

Without it Clang Static Analyzer says "Null pointer passed as an argument to a
'nonnull' parameter" on lines 166 and 168. That ("(s &&") part is to prevent
passing a null pointer to memmove (or memcpy in the previous version of the
code) as a second argument.

(Sorry for the time it took me to reply. I've been preparing for my exams.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160508/4bab3f02/attachment.html>