[Poppler-bugs] [Bug 94173] return dates in UTC format

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun May 15 17:55:40 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=94173

--- Comment #24 from Jakub Kucharski <jakubkucharski97 at gmail.com> ---
(In reply to Albert Astals Cid from comment #22)
> Ok, so I guess you have convinced me, let's give Jakub some time to comment
> about what he thinks of the patches.

Sorry, I've been quiet occupied recently.

I'd prefer if the code of poppler_date_parse() was somehow moved to core and
used by glib and cpp, because now it does the same thing as
detail::convert_date from cpp. This way we could avoid doubling the effort put
into fixing/changing the way time conversion works. I think these two functions
should stay (especially since one (overloaded) version of convert_date is
exported as public API), but they should call a function from core which would
do all the work. But this is of course open for discussion.

Other than that, everything seems ok to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160515/a80857be/attachment.html>


More information about the Poppler-bugs mailing list