[Poppler-bugs] [Bug 95485] [patch] add support for subpixel rendering support for cairo backend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=95485

--- Comment #1 from Adrian Johnson <ajohnson at redneon.com> ---
Comment on attachment 123900
  --> https://bugs.freedesktop.org/attachment.cgi?id=123900
proposed patch

Review of attachment 123900:
-----------------------------------------------------------------

::: glib/poppler-page.cc
@@ +2426,5 @@
>  }
> +
> +gboolean
> +poppler_page_support_subpixel_rendering (PopplerPage        *page)
> +{

This is not a good function name. PDF pages do not "support" subpixel
rendering. The limitation is in cairo not supporting component alpha.

It would be better to call it something like poppler_page_requires_blend_modes.
Maybe this could be generalized to a method of checking what PDF functionality
the page requires. I'm not sure what the glib way of doing this is.

::: poppler/CairoOutputDev.cc
@@ +1422,5 @@
>  
> +  fontType = state->getFont()->getType();
> +  // Do not enable subpixel rendering for type3 font
> +  // For some reason it does not work
> +  if (fontType == fontType3) {

This should be in a separate patch. Also needs an explanation why it is needed
and a test case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160519/df48a052/attachment-0001.html>