[Poppler-bugs] [Bug 97068] document IDs in trailer dict should be printed as hex strings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97068

--- Comment #18 from Jakub Alba <jakubalba at gmail.com> ---
(In reply to Albert Astals Cid from comment #17)
> (In reply to Jakub Alba from comment #13)
> > Created attachment 125498 [details] [review] [review]
> > [PATCH 1/2] introduced hex string as a new Object type and used it for file
> > identifier
> > 
> > (In reply to Albert Astals Cid from comment #12)
> > > After having a look at the first patch, i was wondering if we really need
> > > the "hex" variable in the union, can't we just use string?
> > 
> > I added it, because I'd had some problems when writing this code, but now,
> > when I checked once again, it seems that using string is perfectly OK.
> 
> So can you please update the patches to use string?

They do use string (the variable in the union). They just still introduce a new
enum element just to carry the information if the string is a hex string. Or am
I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20161126/8e5b41b4/attachment.html>