[Poppler-bugs] [Bug 97870] Crash when calling cmsGetColorSpace

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97870

--- Comment #2 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to Marek Kasik from comment #1)
> Created attachment 126645 [details] [review]
> Don't crash when calling cmsGetColorSpace()
> 
> This patch fixes the problem for me.

Is that the only place where all those global variables could be used
uninitialized? GfxColorSpace::setupColorProfiles() is already protected to
ensure it only happens once even if called multiple times, so I think it would
be simpler to call it unconditionally before trying to use RGBProfile. But I
would make this generic, the current use of all those global vars is very weak
in my opinion. I would make a global singleton to contain those variables or
something similar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160920/e5c43bba/attachment.html>