[Poppler-bugs] [Bug 103912] support tags, links, page labels, outline, metadata in cairo backend

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Dec 12 13:41:04 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103912

--- Comment #9 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 135717
  --> https://bugs.freedesktop.org/attachment.cgi?id=135717
Fix some bugs in StructTreeRoot

Review of attachment 135717:
-----------------------------------------------------------------

LGTM

::: poppler/Object.h
@@ +90,5 @@
> +  bool operator() (const Ref& lhs, const Ref& rhs) const {
> +    if (lhs.num != rhs.num)
> +      return lhs.num < rhs.num;
> +    else
> +      return lhs.gen < rhs.gen;

We don't need the else after a return

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171212/65df267c/attachment.html>


More information about the Poppler-bugs mailing list