[Poppler-bugs] [Bug 99271] make it possible to extract digital signature data (also in pdfsig)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99271

--- Comment #15 from oliver.sander at tu-dresden.de ---
Thanks for the new patch.  Three of my issues remain.  Albert, what do you say?

+    if (gstr.getLength() >= end && gstr.getChar(start) == '<' &&
gstr.getChar(end-1) == '>')
+    {
+      ++start;
+      --end;
+      int len = end-start;

'end' and 'start' are of type Goffset.  So shouldn't 'len' be Goffset, too?

+const char *SignatureHandler::getHashAlgorithmName()
+{
+  if (hash_context != nullptr && hash_context->hashobj != nullptr)
+  {
+    switch(hash_context->hashobj->type)
+    {
+      case HASH_AlgMD2:
+        return "MD2";
[snip]
+      case HASH_AlgSHA224:
+        return "SHA-224";
+      default:
+        return nullptr;

Should there be a warning when an unsupported hash algorithm is found?
(Albert, you did say that this was an issue for you, but what is the proposed
solution?)

 struct SignatureValidationInfoPrivate {
-       SignatureValidationInfo::SignatureStatus signature_status;
-       SignatureValidationInfo::CertificateStatus certificate_status;
-
-       QString signer_name;
-       time_t signing_time;
+        SignatureValidationInfo::SignatureStatus signature_status;
+        SignatureValidationInfo::CertificateStatus certificate_status;

Tabs replaced by spaces here.  Intentional?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170615/46a136a4/attachment.html>