[Poppler-bugs] [Bug 99416] Sign PDF with digital signature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99416

--- Comment #8 from Hans-Ulrich Jüttner <huj at froreich-bioscientia.de> ---
(In reply to oliver.sander from comment #7)
> I tried the patch, but it doesn't apply cleanly.  I suppose that's because
> it depends on some incarnation of the patches in
> 
>   https://bugs.freedesktop.org/show_bug.cgi?id=99271
> 
> So getting those in would help with reviewing here.

You are right, this patch depends heavily on the patch #99271.
Unfortunately it started off from that patch as it was in comment 7
before rework after your review on #99271. That results in not applying
cleanly now for this patch. There seems to be hope that we get patch
#99271 in some time soon. Therefore I suggest that I'll revise this
patch then on a clean basis with attention to your comments below.

[snip]

> @@ -535,7 +591,7 @@ GooString* FormWidgetSignature::getCheckedSignature()
>                  break;
>                }
>              }
> -            if (sigLen > 0 && 2*(sigLen+lenBytes) < len-4)
> +            if (sigLen > 0 && 2*(sigLen+lenBytes) <= len-4)
> 
> 
> This smells like a separate bugfix.  Should this go into a separate patch?
> 

Yes this should go into patch #99271 as getCheckedSignature() was added there.

[snip]

Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170616/17a431a9/attachment.html>