[Poppler-bugs] [Bug 100312] Call ansi functions directly, to be able to compile with different -DUNICODE variants

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100312

--- Comment #5 from Adrian Johnson <ajohnson at redneon.com> ---
(In reply to Christoph Cullmann from comment #1)
> Created attachment 130371 [details] [review]
> Updated patch, missed some functions, compiles no in our CI

I agree with explicitly specifying the A or W variant for all win32 API that
takes strings.

The win32 code in gfile.cc should be updated to accept UTF8 strings and convert
to UTF16 and call the W variant to ensure full unicode support. This would
avoid all the win32 specific code in other locations eg PDFDoc.cc line 173. We
should consistently use UTF8 in poppler code and just do the conversion to
wchar_t in the win32 portability code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170323/38e29cb4/attachment.html>