[Poppler-bugs] [Bug 103050] Fix warnings and cleanup unused defs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103050

--- Comment #55 from Adrian Johnson <ajohnson at redneon.com> ---
(In reply to Albert Astals Cid from comment #31)
> > Fix some -Wundef warnings
> 
> I'm actually kind of scared of this patch, we kind of know "it works" as of
> now, and changing this is kind of fragile, but ok i guess

I don't want to commit anything your not entirely happy with. What specifically
concerns you about the patch? It just changes #if ... to #if defined() or
#ifdef for the feature macros. It is less fragile than the existing code where
someone could make a typo eg 
#if ENABLED_LIBZ /* should be ENABLED_ZLIB */

and the code will compile without warnings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171018/a5e1f33b/attachment.html>