[Poppler-bugs] [Bug 103050] Fix warnings and cleanup unused defs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103050

--- Comment #62 from Albert Astals Cid <aacid at kde.org> ---
(In reply to Adrian Johnson from comment #59)
> (In reply to Albert Astals Cid from comment #41)
> > > Make poppler compile of threads not available
> > 
> > I don't understand this one, please explain the rationale of it
> 
> We've got 77 "#ifdef MULTITHREADED" macros all over the code but
> MULTITHREADED is always defined. We should either define MULTITHREADED based
> on whether threads have been detected or just remove the macro. The former
> allows users to build on systems without threads.
> 
> Although the best solution IMHO is too add a no op version of the mutex
> class to GooMutex.h for when threads are not available then all the
> MULTITHREADED macros can be removed.

Hmmm, ok i guess, to be honest i think we shouldn't really worry much about the
non multithreaded case, how did you test this? which system without thread
support did you use?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171020/512f3271/attachment.html>