[Poppler-bugs] [Bug 101692] Add methods to get and set the font or at least font size in a FormFieldText

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 5 21:09:07 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101692

--- Comment #9 from Albert Astals Cid <aacid at kde.org> ---
Any reason you're using isspaces instead of Lexer::isSpace?

In FormFieldText::setTextFontSize if idx is -1 we should give a warning and
skip doing all the work for nothing, no? Should we even return false in that
case?

Also i'd prefer if we return -1 in  FormFieldText::getTextFontSize if the font
size is not found, seems error return like for "it failed" than 0, that while a
weird size i can see some cases in which it is "correct-ish"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170905/84ce74af/attachment.html>


More information about the Poppler-bugs mailing list