[Poppler-bugs] [Bug 101692] Add methods to get and set the font or at least font size in a FormFieldText

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101692

--- Comment #10 from Hans-Ulrich Jüttner <huj at froreich-bioscientia.de> ---
(In reply to Albert Astals Cid from comment #9)
> Any reason you're using isspaces instead of Lexer::isSpace?

No special reason, I just used isspace() from libc because I'm familiar with
it.
If Lexer::isSpace() is equivalent and the preferred way to do it in poppler,
I'll replace isspace() with it.

> 
> In FormFieldText::setTextFontSize if idx is -1 we should give a warning and
> skip doing all the work for nothing, no? Should we even return false in that
> case?

Ok, I'll do that.

> 
> Also i'd prefer if we return -1 in  FormFieldText::getTextFontSize if the
> font size is not found, seems error return like for "it failed" than 0, that
> while a weird size i can see some cases in which it is "correct-ish"

Ok, that reasonable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170906/0abbb8e4/attachment.html>