[Poppler-bugs] [Bug 99416] Sign PDF with digital signature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99416

--- Comment #40 from Albert Astals Cid <aacid at kde.org> ---
(In reply to Adrian Johnson from comment #37)
> (In reply to Albert Astals Cid from comment #33)
> > (In reply to Adrian Johnson from comment #30)
> > > Created attachment 134043 [details] [review] [review] [review]
> > > Return timezone in timeToDateString
> > > 
> > > Here's the fix to make timeToDateString include the time zone in a portable
> > > way.
> > 
> > Adrian, does this mean you're relatively happy with the patch?
> 
> I'm not sure which patch you are referring to.

All of them :D

> Current patch status is:
> 
> 1) Added signing of PDF documents via Qt5 interface and with pdfsig 
> 
> I have a number of major issues with this patch. I have fixed these issues
> in (3).

So you're "happy with conditions" :D

> 
> 2) pdfsig: add -nssdi option v2
> 
> Updated documentation based on your feedback.
> 
> 3) write document then update byte offsets and sig on disk v2
>  
> This fixes all the issues I had with (1).
> 
> 4) Return timezone in timeToDateString
> 
> In comment 15 I requested that the patch use the timeToDateString(). I noted
> that this function currently does not include the timezone. This patch adds
> the time zone. Patch (3) has already changed the signing code to use
> timeToDateString().

This looks good to me.  Hans-Ulrich do patches 2) 3) and 4) also look good for
you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170912/0a540a11/attachment.html>