[Poppler-bugs] [Bug 105796] Render a single annotation with Qt5 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105796

--- Comment #4 from Albert Astals Cid <aacid at kde.org> ---
(In reply to Tobias Deiminger from comment #1)
> Created attachment 138408 [details] [review]
> Move Qt5 output device code out of poppler-page.cc
> 
> Qt5SplashOutputDev, OutputDevCallbackHelper and QImageDumpingArthurOutputDev
> had been defined only locally in poppler-page.cc. Factor them out to be
> reusable by other source files. They're in one file along with
> ArthurOutputDev now.
> 
> Based on master c7a3176.

ArthurOutputDev is quite complex as it is now, I don't think it's a good idea
to add more stuff to that file.

If you want to make those classes available for other files, i'd say
poppler-private.h is more a nice place to have them if you don't want to add a
new file altogether.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180402/7d66521c/attachment.html>