[Poppler-bugs] [Bug 105692] PDF compliance: Always respect Annot Rect

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105692

--- Comment #16 from Tobias Deiminger <haxtibal at posteo.de> ---
Created attachment 138666
  --> https://bugs.freedesktop.org/attachment.cgi?id=138666&action=edit
Alternate all-in-one patch

This patch tries what was discussed in comment 14 and comment 15:
- Get rid of Annot::appearBBox member, local AnnotAppearanceBBox'es are enough.
- Get rid of Annot::getDrawRect again, no longer needed because Annot::rect
always equals draw size.
- Keep the template pattern approach (just my own decision atm)
- Fix AnnotLine, AnnotTextMarkup, AnnotPolygon, AnnotInk by adjusting
Annot::rect (but not annotObj["Rect"]!) to generated appearance. See also [0].
- Fix AnnotText by scaling default appearance (24x24) to size of
annotObj["Rect"].

I did some first tests with Okular and it worked as expected. Albert, what do
you think, can we proceed this way?

Based on master a8e93f4.

[0] If I got it right, Acrobat/Reader handles the case the same. See
https://lists.freedesktop.org/archives/poppler/2012-April/008956.html ("[..]
generate a new bounding box that incorporates the entire line as that is what
one would expect [...]")

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180406/26ab2699/attachment.html>