[Poppler-bugs] [Bug 106137] Crash on PDF with wrong attachment

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106137

Marek Kasik <mkasik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138928|0                           |1
        is obsolete|                            |

--- Comment #4 from Marek Kasik <mkasik at redhat.com> ---
Created attachment 138946
  --> https://bugs.freedesktop.org/attachment.cgi?id=138946&action=edit
Patch fixing this issue - modified

(In reply to Albert Astals Cid from comment #3)
> Why are you adding the FileSpec.cc code? the EmbFile constructor already
> checks for the object being an stream and EmbFile has an isOk you should be
> using. 

It is for the case when the referenced object is null object and not a stream.
I've modified the patch so that the object is tested for being a stream in glib
frontend and does not modify FileSpec.cc at all.

Or we can alternatively fetch the object in constructor of FileSpec and check
for being stream so that isOk() covers also this case.

> I'd prefer not to change that since your change would actually most probably
> break the qt5 frontend code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180420/4ac39b5f/attachment.html>