[Poppler-bugs] [Bug 107151] Add font color in Poppler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107151

--- Comment #23 from Tobias Deiminger <haxtibal at posteo.de> ---
(In reply to Albert Astals Cid from comment #22)
>  * DefaultAppearance name
> Are we sure this is the best name for the class? Wouldn't AnnotAppearance
> make more sense? What's "Default" about this class?
We model the /DA entry here. It's written "default appearance string" in PDF
1.7, P. 396. And because we do some abstraction and our model is no more a
string, I thought we strip "string", and what remains is "DefaultAppearance".

I think we should not mix up /DA with /AP, even if they're similar. AP is the
annotations appearance, while DA establishes context if AP is missing and we
need to create a AP replacement in-memory. DA has limited set of allowed
operators, while AP can do almost everything.

Does this make sense?

Btw., some other PDF libraries expose DA actually as string. See [0]. I don't
think exposing as string is a good idea. Just wanted to mention it, as it might
be the last time we think about that API for a while.

[0]
https://pdfbox.apache.org/docs/2.0.1/javadocs/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationFreeText.html#setDefaultAppearance(java.lang.String)
[1]
https://github.com/gdelugre/origami/blob/98ea557af7aa9e926aac564bf89e6e0ead4a1a5e/lib/origami/annotations.rb#L309

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180816/ccaf0c48/attachment.html>