[Poppler-bugs] [Bug 107151] Add font color in Poppler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107151

--- Comment #29 from Tobias Deiminger <haxtibal at posteo.de> ---
(In reply to Albert Astals Cid from comment #27)
> @@ -2872,7 +2924,8 @@ void AnnotFreeText::generateFreeTextAppearance()
> fontTag is never used not passed anywhere.
Alright. Leak, definitely. Wasn't aware of that place.

How about changing parseAppearanceString signature to
void AnnotFreeText::parseAppearanceString(..., GooString** fontTag)?

Then we can pass nullptr to indicate we don't need the fontTag.
Else we had a useless new-delete cycle in generateFreeTextAppearance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180816/9505e9cf/attachment-0001.html>