[Poppler-bugs] [Bug 103912] support tags, links, page labels, outline, metadata in cairo backend

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 4 05:16:42 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=103912

--- Comment #16 from Adrian Johnson <ajohnson at redneon.com> ---
(In reply to Carlos Garcia Campos from comment #9)
> Comment on attachment 135717 [details] [review]
> Fix some bugs in StructTreeRoot
> 
> Review of attachment 135717 [details] [review]:
> -----------------------------------------------------------------
> 
> LGTM
> 
> ::: poppler/Object.h
> @@ +90,5 @@
> > +  bool operator() (const Ref& lhs, const Ref& rhs) const {
> > +    if (lhs.num != rhs.num)
> > +      return lhs.num < rhs.num;
> > +    else
> > +      return lhs.gen < rhs.gen;
> 
> We don't need the else after a return

I've pushed this patch with the above change as it fixes a couple of other bug
reports. I'll get onto the other patches soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180104/f341a0a2/attachment.html>


More information about the Poppler-bugs mailing list