[Poppler-bugs] [Bug 107057] [Patch] Skip XRef gaps in PDFDoc save methods

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 6 21:59:23 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=107057

--- Comment #13 from Tobias Deiminger <haxtibal at posteo.de> ---
(In reply to Albert Astals Cid from comment #11)
> But we can not have a different problem, no?
Ah thanks, you're right of course. Sorry, I overlooked that.

The new patch in attachment 140484 does basically what you suggested, I just
changed the enum names a bit. I thought it's a bit better to name the actions
"load", instead of "recover", because "load from file if not yet in memory" is
the primary intention of a getEntry() caller if they select the new
LoadSilentlyIfMissing or LoadAndComplainIfMissing option. Recovery is only a
rare secondary step if loading failed.

Had no time to test the new patch yet. I will repeat the steps from comment 1
on Mondays.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180706/615b4200/attachment.html>


More information about the Poppler-bugs mailing list