[Poppler-bugs] [Bug 107151] Add font color in Poppler Qt5 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107151

--- Comment #1 from Tobias Deiminger <haxtibal at posteo.de> ---
Comment on attachment 140496
  --> https://bugs.freedesktop.org/attachment.cgi?id=140496
This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator

Review of attachment 140496:
-----------------------------------------------------------------

::: qt5/src/poppler-annotation.h
@@ +483,5 @@
>      void setTextIcon( const QString &icon );
>  
>      QFont textFont() const;
> +    QColor textColor() const;
> +    void setTextFont( const QFont &font, const QColor &color );

Can we split setTextFont into two?
void setTextFont( const QFont &font );
void setTextColor( const QColor &color );

There are two reasons why: Make it symmetrical to the textFont/textColor get
methods. And more important, changing setTextFont signature would break API and
ABI compatibility of the public poppler-annotations.h interface. Adding a new
non-virtual method however keeps both API and ABI compatible. I don't know the
exact poppler API policy, but that should be considerable anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180708/b29c9968/attachment.html>