[Poppler-bugs] [Bug 107151] Add font color in Poppler Qt5 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107151

--- Comment #5 from Dileep Sankhla <sankhla.dileep96 at gmail.com> ---
(In reply to Tobias Deiminger from comment #4)
> (In reply to Albert Astals Cid from comment #3)
> > I'm not very happy with the appearance creation being in the qt frontend,
> > but well it kind of was there already so i guess we can let it pass, but i
> > really don't like the new method that parses the color, can't we use
> > AnnotFreeText::parseAppearanceString ?
> 
> I definitely agree that creating and parsing DA should be the concern of
> poppler/Annot.cc, probably class AnnotFreeText.
> 
> But Dileep just carried on what was already there, not only regarding
> creation but also regarding parsing: The long existing
> TextAnnotation::textFont also parses DA in Qt5 frontend.
> 
> To be consistent, we should then move all the DA creation and parsing to
> poppler/Annot.cc. Both existing and new functionality. Albert, would that be
> good for you? Dileep, do you think it's possible for you?

As basically I'm working on the project Okular, that uses the Qt5 frontend of
the poppler, I think it should be added and extended to where it has initially
existed. As I passed the second evaluation, I guess it should be marked as
"done" as in the remaining 16 days, I have to accomplish the remaining tasks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180721/08bb0a31/attachment.html>