[Poppler-bugs] [Bug 107151] Add font color in Poppler Qt5 frontend
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Sat Jul 21 18:31:01 UTC 2018
https://bugs.freedesktop.org/show_bug.cgi?id=107151
--- Comment #7 from Tobias Deiminger <haxtibal at posteo.de> ---
"passing second evaluation" was a broad decission. It doesn't mean a particular
patch is ready to land. Albert is the poppler maintainer, he has to be
confident the patch is good for the project before he can merge it. That's
independent from GSoC.
If the patch is sub-par, but the patch was mainly blueprinted from existing
code, then the existing code is sub-par too (see
TextAnnotationPrivate::toAppearanceString, TextAnnotation::textFont). Let's
focus on how to fix both and get this patch ready. I'll come up with some ideas
soon, don't hesitate to be faster.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180721/5dea1ae5/attachment.html>
More information about the Poppler-bugs
mailing list