[poppler] Proposed changes
Albert Astals Cid
tsdgeos at yahoo.es
Fri Mar 4 00:31:23 PST 2005
That is a thing we should discuss deeply. Do we want a complete fork or do we
want a fork where apply fixes but keep close enough to xpdf sources so we can
easily merge future xpdf releases?
My opinion, unless we have much [wo]man power to develop on our own, we should
keep close to xpdf sources and that rules out that "heavy" changes Wilco
proposes.
I mean, if in the future comes out xpdf 4.0, it is much better than poppler
and it can not be merged, the most probable thing is that i would make KPDF
use xpdf sources again.
Albert
A Divendres 04 Març 2005 02:34, Wilco Greven va escriure:
> Hello,
>
> Thank you guys for creating this fork. It's a good to see collaboration
> going on between the Gnome and KDE camp on this front.
>
> I read in the TODO that a goal is to use as much existing infra-structure
> as possible. So as a start I'd like to propose a to replace all GBools by
> ordinary bools (see attached patch, no context in order to save space).
>
> Here are some other proposals that I'd like to discuss
> - Remove VMS specific code.
> - Replace GooString by a string class similar to std::string or QCString,
> which can be better passed by value or const reference, with the goal to
> reduce the number of explicit deletes of strings.
> - Replace GooHash and GooList by template based container classes. These
> can be STL classes or perhaps Qt classes.
>
> The last point might seem a bit far fetched, but it can work. I do have a
> working local copy of xpdf which passes Objects by value and const
> reference. - My pet peeve: Reduce the number of occurences of 'delete' in
> the code. Perhaps pass Objects as value or const reference. The result will
> be code which is more readable.
>
> The autogen.sh didn't work for me. I've copied one from cairo and changed
> it a bit. I've attached it to this email.
>
> Wilco
___________________________________________________
Yahoo! Messenger - Nueva versión GRATIS
Super Webcam, voz, caritas animadas, y más...
http://messenger.yahoo.es
More information about the poppler
mailing list