[poppler] [PATCH 4/5] use libjpeg for DCTStream

Kristian Høgsberg krh at bitplanet.net
Fri Mar 11 13:53:34 PST 2005


Jeff Muizelaar wrote:
> This patch has auto* stuff that is really rough
> 
> 2005-03-02  Jeff Muizelaar  <jrmuizel at nit.ca>
> 
> 	* configure.ac: Add check for libjpeg.
> 
> 	* DCTStream.cc, DCTStream.h, Stream.cc, Stream.h, Makefile.am:
> 	Conditionally use libjpeg instead of xpdf jpeg decoder.

This is now committed, I fixed up the configure check to work more like 
the cairo check: use libjpeg by default, but don't fail if it's no 
found.  If --enable-libjpeg is given, fail if it's not found.  If 
--disable-libjpeg is given, well, don't use it.  I've tested it on a few 
PDF's and see no difference from the xpdf decoder.  Let's give it a try, 
if we discover too many regressions down the road we can switch it back.

Also, a stylistic change: I removed the file scope #ifdef ENABLE_LIBJPEG 
#endif pairs, compiling an empty file is just wrong.  Instead I moved 
the condition into poppler/Makefile.am so it's the same mechanism that 
we use for cairo and splash.

cheers,
Kristian


More information about the poppler mailing list