[poppler] Fwd: [Patch] improving poppler's QT interface
Brad Hards
bradh at frogmouth.net
Mon Nov 21 01:54:46 PST 2005
On Friday 18 November 2005 08:45 am, Albert Astals Cid wrote:
> Hi, Stefan wants this patch for Qt interface in, i find it quite correct,
> anyone has any objection?
Looks OK (although I would have liked unified diff). A few minor suggestions
are below.
> * In the class "Page" a new method getTextList() is introduced that
> returns a list of TextBoxes that represent all the text on a page.
textsList() might be a better name.
> * In the class "Page" a new method getOrientation() is introduced that
> returns the orientation of the page. An enum with all possible
> orientations is also provided.
orientation(), please - to match the Qt convention and be the same as the Qt4
bindings.
Otherwise, OK to apply.
Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20051121/ed6083bd/attachment.pgp
More information about the poppler
mailing list