[poppler] [big patch] Document attachment support

[Albert Astals Cid]

A Dijous 29 Desembre 2005 10:32, Brad Hards va escriure:
> The attached patch is a refined version of the patch I originally posted in
> August. This version properly supports the description element and has
> decent unit tests. I'll commit the test cases soon. Feedback appreciated.

I'm attaching a modified by me patch, the patch has:
 - The improved ::data loop mentioned in the other mail
 - Some build fixes (the patch was for before we had PageTransition)
 - A fix to my UGooString patch (one delete -> delete[])
 - Changed QList<EmbeddedFile> to QList<EmbeddedFile*> as i've now changed the 
class to free the Stream (having no leaks on check_attachments or so says 
valgrind) but that needed the EmbeddedFile to be deleted before the PDFDoc so 
i've made it this way and seems to work.

Brad, what do you think?

Albert

>
> Right now there are only qt4 bindings, and while it works, it doesn't feel
> quite right yet (valgrind tells me there is a couple of huge memory leaks).
> There is an easier way - just copy the whole file out on initialisation,
> however this will slow down the startup parsing for every file with
> attachments, so I don't want to do that.
>
> Can the glib experts give this some thought, and describe what sort of API
> will work for them?
>
> For the kpdf/kviewshell guys, can you have a look at the current Qt4 API
> and provide feedback?
>
> Leonard: in your original review, you suggested  that there was a variation
> on this that dates back to PDF1.2. Do you have an example?
>
> Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attaches.diff
Type: text/x-diff
Size: 52001 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20060102/16ce9393/attaches-0001.bin