[poppler] [big patch] Document attachment support
Brad Hards
bradh at frogmouth.net
Wed Jan 18 11:36:51 PST 2006
On Tuesday 03 January 2006 03:06 am, Albert Astals Cid wrote:
> A Dijous 29 Desembre 2005 10:32, Brad Hards va escriure:
> > The attached patch is a refined version of the patch I originally posted
> > in August. This version properly supports the description element and has
> > decent unit tests. I'll commit the test cases soon. Feedback appreciated.
>
> I'm attaching a modified by me patch, the patch has:
> - The improved ::data loop mentioned in the other mail
> - Some build fixes (the patch was for before we had PageTransition)
> - A fix to my UGooString patch (one delete -> delete[])
> - Changed QList<EmbeddedFile> to QList<EmbeddedFile*> as i've now changed
> the class to free the Stream (having no leaks on check_attachments or so
> says valgrind) but that needed the EmbeddedFile to be deleted before the
> PDFDoc so i've made it this way and seems to work.
I am not going to get to this anytime soon, so I think you should apply this
now, and work with jrb (and myself, if I get time) to sort out what needs to
be changed to support the glib bindings (plus Qt3 bindings, maybe).
Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20060119/b4ea63b7/attachment.pgp
More information about the poppler
mailing list