[poppler] [PATCH] Sound and page actions support in poppler (and Qt4 backend)

[Albert Astals Cid]

A Dimarts 03 Octubre 2006 20:17, Pino Toscano va escriure:
> Hello,
>
> my name is Pino Toscano, and I'm one of the okular developers.
>
> I've written a patch for supporting sounds and page actions, and an
> addition patch for the Qt4 backend to support these new features.

For me they seem quite good patches, but it would be better if someone not 
from the okular camp can have a look at them too.

> While developing the sound support in the Qt4 backend, I saw the code for
> decoding a file specification structure is in the LinkAction class. That is
> not too versatile, as even an external sound can be represerented by a file
> specification. My idea would be factor out that code in eg a function
> (static, or in namescape, or I don't know where) like
>   GooString * readFileSpec(Object *obj, GooString *baseURI);
> that should take a file specification dictionary/string object and the base
> uri and return the (full?) name of the file.

Don't know which would be the best place, globalparams is somewhat static but 
does not seem to be the right place for that.

Anyone has a good suggestion :-/

Albert

>
> What do you think?
>
> Regards,