[poppler] [PATCH] Sound and page actions support in poppler (and Qt4 backend)

Brad Hards bradh at frogmouth.net
Wed Oct 4 01:06:13 PDT 2006

On Wednesday 04 October 2006 04:17, Pino Toscano wrote:
> I've written a patch for supporting sounds and page actions, and an
> addition patch for the Qt4 backend to support these new features.
I only had a quick look at the code - nothing too objectionable :-)
* I would like to see a unit test (and whatever test files are necessary) that 
verifies all of the functionality.
* There are a couple of new files that don't have appropriate (GPL) licensing. 
Please fix.
* A couple of non-ascii characters in the API documentation (for the 
SoundEncoding enum), and one API documentation entry that could be clearer 
(for channels() - did you want something like: "The number of sound channels 
to use to play the data"?
* You appear to be documenting SoundData, not SoundObject. Also, it would be 
nice to provide an overview of how sound works in this API. As a minimum, 
please provide a reference to the relevant section in the PDF spec.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20061004/3e951448/attachment.pgp

More information about the poppler mailing list