[poppler] [PATCH] Sound and page actions support in poppler (and Qt4 backend)

[Pino Toscano]

Alle 10:06, mercoledì 4 ottobre 2006, Brad Hards ha scritto:
> I only had a quick look at the code - nothing too objectionable :-)

:)

> * I would like to see a unit test (and whatever test files are necessary)
> that verifies all of the functionality.

The problem is that there's no "direct" way to "reach" a sound. I mean, for 
example the embedded files can be part of the document, so it's easy to read 
and get them. For sounds, they can be part of an action, or an annotation.

> * There are a couple of new files that don't have appropriate (GPL)
> licensing. Please fix.

Fixed.

> * A couple of non-ascii characters in the API documentation (for the
> SoundEncoding enum), and one API documentation entry that could be clearer
> (for channels() - did you want something like: "The number of sound
> channels to use to play the data"?

Removed the non-ascii character in flavour of the 'mu' string, and adjusted 
the channels() apidox according to your suggestion.

> * You appear to be documenting SoundData, not SoundObject. Also, it would
> be nice to provide an overview of how sound works in this API. As a
> minimum, please provide a reference to the relevant section in the PDF
> spec.

Fixed the SoundData/SoundObject thing, and added some notes about the usage of 
a SoundObject and the parsing of the sound Stream.

Regards,

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20061004/a09902e8/attachment.pgp