[poppler] Annot Improving (IV)

Albert Astals Cid aacid at kde.org
Fri Dec 7 16:19:26 PST 2007


A Dijous 06 Desembre 2007, Iñigo Martínez va escriure:
> Hi:
>
> Here goes another path. Very small one. It's about the PDFRectangle
> proposal.
>
> I have another questions with this one too.
>
> 1. What for are getXMin and getYMin ? I mean, they aren't used anywhere
> (I haven't found any place where  they are used).
> 2. Shouldn't be better to encapsulate PDFRectangle, doing x1,x2,y1 and
> y2 private and implementing getters and setters ? (anyway this is an
> aesthetically change).

No aesthetically changes for the sake of them please, that just makes merging 
more difficult.

Albert

>
> Off topic: I have forgot to mention that I have been late sending back
> these changes because at the moment I'm unemployed and I have been
> searhing a new job. Sorry!
>
> Bye,




More information about the poppler mailing list