[poppler] [PATCH and RFC] Bugfixes, Improved Forms Support for Unicode

Michael Vrable mvrable at cs.ucsd.edu
Sun Feb 3 11:31:34 PST 2008

On Sun, Feb 03, 2008 at 04:38:42PM +0100, Carlos Garcia Campos wrote:
> Hi Michael, thank you very much for the patches. I have tested them 
> with several documents and it works pretty well. The only thing that 
> it's still broken is multiline form fields. It was already broken 
> indeed (see bug http://bugzilla.gnome.org/show_bug.cgi?id=499939) but 
> in a different way. Now it seems to enter into an infinite loop after 
> editing a multiline form field.
> You can use this file to reproduce the problem:
> http://www.okular.org/stuff/forms-scribus.pdf

You're right, there is an infinite loop.  It should be fixed now--the 
test file was very helpful for spotting the problem.

The attached infinite-loop.patch fixes this problem.  The problem was in 
the code that strips trailing space from a line when wrapping.  While 
there, I made another fix so that it does not skip over spaces following 
a newline character--though I think there are still a few corner cases 
where line-wrapping may not be quite correct.  I'll continue to do some 
testing and work on this.

I'm also attaching a new version of the original patch with this fix 

--Michael Vrable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: infinite-loop.patch
Type: text/x-diff
Size: 1113 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20080203/2e3c454e/attachment-0002.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unicode-forms-support.patch
Type: text/x-diff
Size: 22448 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20080203/2e3c454e/attachment-0003.patch 

More information about the poppler mailing list