[poppler] [PATCH] Add setContents() to modify the annot contents

Albert Astals Cid aacid at kde.org
Sun Apr 19 14:41:44 PDT 2009


A Dissabte, 18 d'abril de 2009, Carlos Garcia Campos va escriure:
> Hi all,
>
> we are still lacking write support in annotations. This patch, to be
> able to modify the contents of an annotation, it's just a first step.
>
> ok to commit?

contents = new GooString(new_content);

crashes if new_content is null, so you either protect this or remove the 
protection in 

if (new_content && !contents->hasUnicodeMarker()) {

I think obj1 is missing a free().

Also you should probably update the modified member too.

Otherwise it think this can't hurt to let it go in :D

Albert


More information about the poppler mailing list