[poppler] [PATCH] Add setContents() to modify the annot contents

[Carlos Garcia Campos]

El dom, 19-04-2009 a las 23:41 +0200, Albert Astals Cid escribió:
> A Dissabte, 18 d'abril de 2009, Carlos Garcia Campos va escriure:
> > Hi all,
> >
> > we are still lacking write support in annotations. This patch, to be
> > able to modify the contents of an annotation, it's just a first step.
> >
> > ok to commit?
> 
> contents = new GooString(new_content);
> 
> crashes if new_content is null, so you either protect this or remove the 
> protection in 

fair enough. It makes me wonder what should we do in this case, I mean,
the Contents field is optional in the annotation array, should we remove
the key from the dict when NULL is set? or shouldn't we even allow
passing NULL to setContents()?

> if (new_content && !contents->hasUnicodeMarker()) {
> 
> I think obj1 is missing a free().

No, because it's owned by the Dict. 

> Also you should probably update the modified member too.

What do you mean with the modified member?

> Otherwise it think this can't hurt to let it go in :D

Great, I'll commit it when I know what to do with the NULL case. 

Thanks.

> Albert
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
-- 
Carlos Garcia Campos
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
 digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090420/a14c7fba/attachment.pgp