[poppler] patch for pdftopng

[Shen Liang]

I merged pdftopng to pdftoppm. It works as "pdftoppm -png" now. Maybe
it should be something like "pdf2image" in the future and get more
format to support.

On Sun, Jun 7, 2009 at 6:15 AM, Albert Astals Cid<aacid at kde.org> wrote:
> A Divendres, 29 de maig de 2009, Shen Liang va escriure:
>> patch for pdftopng
>
> The SplashBitmap::writePNGFile implementation has lots of commented code
> (either remove it if not needed or uncomment it if needed) and also doesn't
> implement nor gives errors case splashModeMono8: and some others.
>
> Also pdftopng.cc is 99.01% similar to pdftoppm.cc it would be a great idea if
> the code was either merged in and splitted into a separate file. Having
> duplicate code is a nightmare when speaking of maintainership.
>
> Albert
>
>>
>> ---------- Forwarded message ----------
>> From: Shen Liang <shenzhuxi at gmail.com>
>> Date: Tue, May 26, 2009 at 12:47 PM
>> Subject: Re: [poppler] Fwd: Donate some codes for poppler
>> To: Albert Astals Cid <aacid at kde.org>
>>
>>
>> I'm sorry I got a mistake on the attach.
>>
>> On Sat, May 23, 2009 at 5:57 PM, Albert Astals Cid <aacid at kde.org> wrote:
>> > A Divendres, 22 de maig de 2009, Shen Liang va escriure:
>> >> I'd like to donate some codes for Poppler. I added pdftopng by
>> >> modifying pdftoppm. The codes were quit dirty now, and I will do more
>> >> later.
>> >
>> > Hi, thanks for contributing to poppler :-)
>> >
>> > Unfortunately the zip you attach is not correct.
>> >
>> > First for pdftopng you are attaching a shell scripts instead of the code.
>> >
>> > Second for already existing files like SplashBitmap.[cc|h] you should
>> > attach a diff file as generated by git diff if you use git or diff -u if
>> > you are working on released tarballs.
>> >
>> > Albert
>> >
>> > _______________________________________________
>> > poppler mailing list
>> > poppler at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/poppler
>>
>> --
>> Help Si Chuan Students
>> 帮助四川灾区学生
>> https://match.sichuanteachers.org
>> 四川教师志愿者组织
>
>
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>



-- 
Help Si Chuan Students
帮助四川灾区学生
https://match.sichuanteachers.org
四川教师志愿者组织
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SplashBitmap.patch
Type: text/x-patch
Size: 2456 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090614/4974b35b/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pdftoppm.patch
Type: text/x-patch
Size: 1740 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090614/4974b35b/attachment-0001.bin