[poppler] Moving from qsort to std::sort

[Leonard Rosenthol]

I think replacing the custom container classes with the std:: containers will be a big win across the board - performance, maintenance, stability, etc.  The std:: classes have had a LOT of folks work on them and they've been deployed in a LOT more solutions.  Use them.

While getting rid of goostring with std::string might also be appealing, I think that's a larger issues that wouldn't benefit as much as the containers.

Leonard

-----Original Message-----
From: poppler-bounces+leonardr=adobe.com at lists.freedesktop.org [mailto:poppler-bounces+leonardr=adobe.com at lists.freedesktop.org] On Behalf Of Albert Astals Cid
Sent: Thursday, August 26, 2010 6:28 PM
To: poppler at lists.freedesktop.org
Subject: [poppler] Moving from qsort to std::sort

Yes, i know i've been a huge non std:: proponent in poppler for long time 
being a PITA for lots of people.

But these people where using lists or strings for which we have a "solution" 
that works for our use cases as well as the std ones.

Now qsort vs std::sort is a interesting story, i get up to 30% speedups 
(callgrind says) (in the function itself, obviously not in the total runtime) 
just exchanging qsort for std::sort.

So let's discuss if we want to allow std or not. And if we allow it, are we 
going all in? Or just allow some cases? But which?

Opinions?

Albert
_______________________________________________
poppler mailing list
poppler at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler