[poppler] Bugfix proposal for Shading Type 6 and 7

[Christian Feuersaenger]

Dear Albert,

thank you for your time to perform the regression tests!

I have fixed the bug; it was a data type problem.

Attached you find the fixed version.

The file
bugfix_shadingtype4567_incremental.patch
is relative to the version you used for the regression tests.

The file
bugfix_shadingtype4567_poppler0.14.patch
is relative to poppler-0.14.0-3-gb2427d0 .

Thank you for considering my contributions.

Best regards

Christian


Am 25.07.2010 16:56, schrieb Albert Astals Cid:
> A Dissabte, 3 de juliol de 2010, Christian Feuersaenger va escriure:
>> Hello Albert,
>
> Hi
>
>>
>> I've managed to fix a bug in the Shading Type 6/7 (Coons&  cubic tensor
>> patches) implementation.
>>
>> The bugfix is small and stable (in my eyes); the poppler-0.14 branch
>> doesn't implement support for parameterized patch shadings. I modified
>> the existing implementation accordingly with relatively few changes.
>>
>> Attached you find the patch file and the updated test.pdf to see the
>> improvement.
>>
>> The file type4567patch.... also includes the patch of my previous mail
>> (they only share the same refinement threshold).
>>
>> The patch should work relative to poppler-0.14.0-3-gb2427d0 .
>
> This patch causes a regression in the attached pdf (the blue area disappears)
>
> Albert
>
>>
>> Best regards
>>
>> Christian
>>
>>
>> _______________________________________________
>> poppler mailing list
>> poppler at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/poppler

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfix_shadingtype4567_poppler0.14.patch
Type: text/x-patch
Size: 23567 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20100727/1884e9c7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfix_shadingtype4567_incremental.patch
Type: text/x-patch
Size: 3345 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20100727/1884e9c7/attachment-0003.bin>