[poppler] Bugfix proposal for Shading Type 6 and 7

[Albert Astals Cid]

A Dimarts, 27 de juliol de 2010, Christian Feuersaenger va escriure:
> Dear Albert,
> 
> thank you for your time to perform the regression tests!
> 
> I have fixed the bug; it was a data type problem.
> 
> Attached you find the fixed version.
> 
> The file
> bugfix_shadingtype4567_incremental.patch
> is relative to the version you used for the regression tests.
> 
> The file
> bugfix_shadingtype4567_poppler0.14.patch
> is relative to poppler-0.14.0-3-gb2427d0 .
> 
> Thank you for considering my contributions.

I've ran the regression test with the Splash outputdev and all looks ok, will 
have to run it over the cairo and ps outputdevs before committing, though 
it'll take a while since next week i'm going to be away on holidays.

Albert

> 
> Best regards
> 
> Christian
> 
> Am 25.07.2010 16:56, schrieb Albert Astals Cid:
> > A Dissabte, 3 de juliol de 2010, Christian Feuersaenger va escriure:
> >> Hello Albert,
> > 
> > Hi
> > 
> >> I've managed to fix a bug in the Shading Type 6/7 (Coons&  cubic tensor
> >> patches) implementation.
> >> 
> >> The bugfix is small and stable (in my eyes); the poppler-0.14 branch
> >> doesn't implement support for parameterized patch shadings. I modified
> >> the existing implementation accordingly with relatively few changes.
> >> 
> >> Attached you find the patch file and the updated test.pdf to see the
> >> improvement.
> >> 
> >> The file type4567patch.... also includes the patch of my previous mail
> >> (they only share the same refinement threshold).
> >> 
> >> The patch should work relative to poppler-0.14.0-3-gb2427d0 .
> > 
> > This patch causes a regression in the attached pdf (the blue area
> > disappears)
> > 
> > Albert
> > 
> >> Best regards
> >> 
> >> Christian
> >> 
> >> 
> >> _______________________________________________
> >> poppler mailing list
> >> poppler at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/poppler