[poppler] Form-Reset and Print [patches]

[Albert Astals Cid]

A Diumenge, 13 de juny de 2010, Carlos Garcia Campos va escriure:
> Excerpts from Guillermo Amaral's message of dom jun 13 04:40:44 +0200 2010:
> > Albert Astals Cid <aacid at kde.org> wrote:
> > > A Dissabte, 12 de juny de 2010, Guillermo Amaral va escriure:
> > >> I wanted to send in these patches, they allow handling of reset-form
> > >> and print actions respectably.
> > >> 
> > >> Please check them out, and if you have any questions please don't
> > >> hesitate to ask.
> > > 
> > > Do you have a document that uses them?
> > > 
> >   I do, but I dunno if I can share them ATM, looking into it.
> >   But I did make a test pdf that uses both features. :-)
> >   
> > > Also what is the point of
> > > 
> > > +  } else if (obj2.isName("ResetForm")) {
> > > +    action = new LinkResetForm(obj2.getName());
> > > 
> >   As usual, you are right aacid :) I try a little to hard not to break
> >   the flow of other programs, I think I went to far lol (fixed)
> >   
> > > And
> > > if (obj->dictLookup("AA", &tmp)->isDict())
> > > seems like an unrelated fix, can you please explain it too?
> > > 
> >   Mixed them up, that one should be in the print patch (moved). Sometimes
> >   the AA dict is used to hold a ref to the named object. I have seen it
> >   in two docs so far, it seems to happen when people set an action to
> >   happen on mouse down instead of mouse up. It should not break anything
> >   else (as far as I can see).
> 
> We should definitely add support for additional actions properly in
> poppler.

Well, the problem seems to be that the poppler-qt4 form handling is somewhat 
disconnected from poppler core form handling, anyone working on integration 
will get cookies/beer/orangejuice from me.

Albert