[poppler] [PATCH] Arthur backend fixes; poppler-qt4 direct rendering

[Albert Astals Cid]

Please never answer me only, always mail the list.

A Dimarts, 2 de novembre de 2010, Matthias Fauconneau va escriure:
> > Please don't leave commented code behind, like
> > //state->transform(x, y, &x1, &y1);
> > If we don't need it, just remove it.
> > 
> > Also you seem to not use buffer anymore but didn't remove the declaration
> > 
> > + \warning This method is only supported for Arthur and Cairo Qt backends
> > +
> > + \since 0.6
> > Also i please do not to copy code from renderToImage to renderToQPainter,
> > copying code is bad. Another nice thing would be if the new method
> > returned a
> > bool so that if you actually try to use it with a Splash backend you
> > return false.
> 
> Fixed them all.

Good.

> 
> > There is no Cairo Qt backend
> 
> Actually there is (I even tried it), but it is much worse than using
> Arthur directly

No, there is not, there are unofficial patches for it, but that's all.

> 
> > Thanks for the work.
> 
> I also fixed two memory leaks in Arthur. They probably didn't show
> because nobody was calling the renderer 40 times per seconds :D

It's wrong, look at how splashoutputdev does it (yes i know it sucks)

> 
> I attached two screenshots so you can compare the backends on these
> particular files.
> I don't know why Qt OpenGL rendering is "fatter" but I like it.
> While with Splash, the notes heads and tails are not quite fitting.

No way we can tell without having the files, probably Arthur is doing 
antialias and Splash is not.

Albert