[poppler] Followup Bug 32349 & Poppler: More shading fun ;-)
Albert Astals Cid
aacid at kde.org
Tue Jan 25 13:25:17 PST 2011
A Dimarts, 25 de gener de 2011, Andrea Canciani va escriure:
> On Tue, Jan 25, 2011 at 9:00 PM, Albert Astals Cid <aacid at kde.org> wrote:
> > ...
> >> Finished successfully, i'll have a look at the code tomorrow and if i
> >> don't find anything obviously wrong will commit it to master :-)
> > Had a look at the code and it is too untidy, please remove all the ifdefs
> > of unused code and remove the T_EDGE and T_CORNER defines and i'll
> > commit it.
> 0001 and 0002 replace most of Thomas's patch, the exception being
> attachment 0003. I don't understand what is the purpose of that change,
> maybe Thomas can explain it and suggest a better commit message.
> I think 0001 and 0002 should be quite clean and commit ready.
> Please review them, I'll fix any remaining problem as soon as possible.
Hmm, sincerely i prefer to commit Thomas patches first. It has taken us lots
of regtesting iterations to get to something that gives improvements and no
regressions. Once that is in we can start with your patches :-)
More information about the poppler