[poppler] Patch for poppler TextOutputDev WAS bug in poppler-0.21.0 and patch

[Marek Kasik]

Hi,

I'm sorry for my late answer (my filters vs. inbox).

Yes, the patch does what I intended originally.

The cycle processes just those text blocks which are not part of any
table. These have tableId set to -1 in TextBlock's constructor.

The cycle set maximal x coordinates of extended bounding box of actual
block so that it doesn't overlap with another blocks and its x
coordinates are aligned to x coordinates of a block above this one.

Regards

Marek


On 11/12/2012 12:34 AM, Albert Astals Cid wrote:
> El Dilluns, 22 d'octubre de 2012, a les 11:41:41, Peter Breitenlohner va 
> escriure:
>> Hi,
>>
> 
> Hi Marek,
>   can you confirm that this patch is indeed what you wanted to do?
> 
> Cheers,
>   Albert
> 
>> I think you should apply the patch
>> ===
>> From be8740ad6e78c38ba20e7a3b790b9fbd052b5cb5 Mon Sep 17 00:00:00 2001
>> From: Peter Breitenlohner <peb at mppmu.mpg.de>
>> Date: Mon, 22 Oct 2012 11:34:51 +0200
>> Subject: [PATCH] Correct bad semantics
>>
>> Negation has higher precedence than comparison
>>
>> Signed-off-by: Peter Breitenlohner <peb at mppmu.mpg.de>
>> ---
>>   poppler/TextOutputDev.cc |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/poppler/TextOutputDev.cc b/poppler/TextOutputDev.cc
>> index 2be0b42..2638c3b 100644
>> --- a/poppler/TextOutputDev.cc
>> +++ b/poppler/TextOutputDev.cc
>> @@ -3371,7 +3371,7 @@ void TextPage::coalesce(GBool physLayout, double
>> fixedPitch, GBool doHTML) { *  so that they extend in x without hitting
>> neighbours
>>      */
>>     for (blk1 = blkList; blk1; blk1 = blk1->next) {
>> -    if (!blk1->tableId >= 0) {
>> +    if (!(blk1->tableId >= 0)) {
>>         double xMax = DBL_MAX;
>>         double xMin = DBL_MIN;